diff --git a/README.md b/README.md index 665933a..6dbc6b6 100644 --- a/README.md +++ b/README.md @@ -9,10 +9,10 @@ This solver can be used with [desec.io](https://desec.io) DNS API. The documentation of the API can be found [here](https://desec.readthedocs.io/en/latest/) ## Requirements -- [go](https://golang.org) => 1.26.0 +- [go](https://golang.org) >= 1.26.0 - [helm](https://helm.sh/) >= v3.0.0 -- [kuberentes](https://kubernetes.io/) => 1.25.0 -- [cert-manager](https://cert-manager.io/) => 1.19.0 +- [kubernetes](https://kubernetes.io/) >= 1.25.0 +- [cert-manager](https://cert-manager.io/) >= 1.19.0 ## Installation @@ -75,7 +75,7 @@ spec: key: token name: desec-io-token groupName: acme.pr0ton11.github.com - solverName: desec + solverName: deSEC ``` ## Create a manual certificate @@ -150,7 +150,7 @@ data: type: Opaque ``` -Define a **TEST_ZONE_NAME** matching to your authenticaton creditials. +Define a **TEST_ZONE_NAME** matching to your authentication credentials. ```bash $ TEST_ZONE_NAME=example.com. make test diff --git a/main_test.go b/main_test.go index e4ad374..9651134 100644 --- a/main_test.go +++ b/main_test.go @@ -1,6 +1,7 @@ package main import ( + "os" "testing" acmetest "github.com/cert-manager/cert-manager/test/acme" @@ -21,9 +22,13 @@ func TestRunsSuite(t *testing.T) { // acmetest.SetManifestPath("testdata/my-custom-solver"), // acmetest.SetBinariesPath("_test/kubebuilder/bin"), //) - solver := &solver.DeSECDNSProviderSolver{} - fixture := acmetest.NewFixture(solver, - acmetest.SetResolvedZone("example.com."), + desecSolver := &solver.DeSECDNSProviderSolver{} + zoneName := os.Getenv("TEST_ZONE_NAME") + if zoneName == "" { + t.Skip("TEST_ZONE_NAME not set") + } + fixture := acmetest.NewFixture(desecSolver, + acmetest.SetResolvedZone(zoneName), acmetest.SetManifestPath("testdata/desec"), acmetest.SetDNSServer("127.0.0.1:59351"), acmetest.SetUseAuthoritative(false),